-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactored settings.py for test-derivatives #75
refactored settings.py for test-derivatives #75
Conversation
# examples # | ||
############################################################################### | ||
|
||
example = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a conv example
"input_kwargs": {"size": (4, 3, 4, 5)}, | ||
}, | ||
{ | ||
"module_fn": torch.nn.ZeroPad2d, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a new file for paddings
Activation layers | ||
Convolutional layers | ||
Linear Layers | ||
Loss functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add padding layers
test/core/derivatives/problem.py
Outdated
def derivative_prefix_for(self): | ||
self.derivative = self.make_derivative() | ||
if is_activation(self.derivative): | ||
prefix = "act" | ||
elif is_layer(self.derivative): | ||
prefix = "layer" | ||
elif is_pooling(self.derivative): | ||
prefix = "pool" | ||
elif is_loss(self.derivative): | ||
prefix = "loss" | ||
else: | ||
prefix = "" | ||
return prefix | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought a bit more about it and saw the modified names in the failing travis run. Now I think this does not add sufficient new information. If s.o. is developing a new MyLayer
, it's possible to filter the tests with
pytest -vx . -k MyLayer
Could you undo this prefixing? I might have missed an argument.
This request contains refactoring of settings for test-derivatives.