Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use a slightly different config for testing and production #20

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

AshesOfEther
Copy link
Contributor

This is useful for things where we need to have a slightly different configuration for testing locally. Currently it's primarily for the domain name, but it will likely also prove useful for things like Stregsystemet, where we want to use test data locally and then real data in production.

Copy link
Member

@Mast3rwaf1z Mast3rwaf1z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would just call prod fklub instead of fklub-prod for consistency with hostname, since my own systems choose their flake based on hostname. This obvs doesn't matter if we're deploying in GitHub actions anyway tho. Up to you.

@AshesOfEther AshesOfEther merged commit c019f3f into main Mar 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants