Optimize multibuy database queries #469
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krestenlaust
changed the title
| @@ -128,15 +128,15 @@ def execute(self): | |||
| self.member = Member.objects.select_for_update().get(id=self.member.id) | |||
| self.member.fulfill(transaction) | |||
|
|
|||
| # Collect all the sales of the order | |||
| Sales = [] | |||
There was a problem hiding this comment.
Suggested change
| Sales = [] | |
| sales = [] |
| for i in range(item.count): | ||
| s = Sale(member=self.member, product=item.product, room=self.room, price=item.product.price) | ||
| s.save() | ||
| Sales.append(s) |
There was a problem hiding this comment.
Suggested change
| Sales.append(s) | |
| sales.append(s) |
|
I'll try to review this before summer ends. Probably after the current update has been finished |
|
@Mast3rwaf1z Vil du ikke være en king og review den her så Kresten kan få lidt fritid? |
|
|
Tager lige et kig senere, var lige til forelæsning |
Mast3rwaf1z
requested changes
Sep 9, 2024
| s.save() | ||
| Sales.append(s) | ||
| # Save all the sales | ||
| Sale.objects.bulk_create(Sales) |
There was a problem hiding this comment.
Suggested change
| Sale.objects.bulk_create(Sales) | |
| Sale.objects.bulk_create(sales) |
Comment on lines
+719
to
+722
| if str(unique_id) not in unique_product_dict: | ||
| unique_product_dict[str(unique_id)] = 1 | ||
| else: | ||
| unique_product_dict[str(unique_id)] += 1 |
There was a problem hiding this comment.
Suggested change
| if str(unique_id) not in unique_product_dict: | |
| unique_product_dict[str(unique_id)] = 1 | |
| else: | |
| unique_product_dict[str(unique_id)] += 1 | |
| if unique_id not in unique_product_dict: | |
| unique_product_dict[unique_id] = 1 | |
| else: | |
| unique_product_dict[unique_id] += 1 |
what's the point in converting from an int object to string all the time?
There was a problem hiding this comment.
you can also optimize it further by just using dict comprehension:
unique_product_dict = {i:bought_ids.count(i) for i in bought_ids}
Comment on lines
+725
to
730
| for i in unique_product_dict: | ||
| product = Product.objects.get( | ||
| Q(pk=i), | ||
| Q(active=True), | ||
| Q(deactivate_date__gte=time_now) | Q(deactivate_date__isnull=True), | ||
| Q(rooms__id=room.id) | Q(rooms=None), |
There was a problem hiding this comment.
Suggested change
| for i in unique_product_dict: | |
| product = Product.objects.get( | |
| Q(pk=i), | |
| Q(active=True), | |
| Q(deactivate_date__gte=time_now) | Q(deactivate_date__isnull=True), | |
| Q(rooms__id=room.id) | Q(rooms=None), | |
| for key, value in unique_product_dict.items(): | |
| product = Product.objects.get( | |
| Q(pk=key), | |
| Q(active=True), | |
| Q(deactivate_date__gte=time_now) | Q(deactivate_date__isnull=True), | |
| Q(rooms__id=room.id) | Q(rooms=None), |
| product = Product.objects.get( | ||
| Q(pk=i), | ||
| Q(active=True), | ||
| Q(deactivate_date__gte=time_now) | Q(deactivate_date__isnull=True), | ||
| Q(rooms__id=room.id) | Q(rooms=None), | ||
| ) | ||
| products.append(product) | ||
| products.extend([product for x in range(unique_product_dict[str(i)])]) |
There was a problem hiding this comment.
Suggested change
| products.extend([product for x in range(unique_product_dict[str(i)])]) | |
| products.extend([product for _ in range(value)]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #357.