CLI foundations #77
Merged
CLI foundations #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safareli
reviewed
Jun 5, 2018
.travis.yml
Outdated
| @@ -4,7 +4,9 @@ dist: trusty | |||
| sudo: required | |||
| node_js: stable | |||
| install: | |||
| - npm install | |||
| - bower install --production | |||
| - npm install -g bower pulp [email protected] | |||
There was a problem hiding this comment.
npm i will install this libs too so there should be no need for this.
also in travis, binaries of all installed npm libs is available in PATH
safareli
reviewed
Jun 5, 2018
package.json
Outdated
| @@ -4,6 +4,7 @@ | |||
| "description": "", | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "preinstall": "bower install --production && pulp build -t chanterelle.js", | |||
There was a problem hiding this comment.
I think you need postinstall
|
yeah i think postinstall will allow me to not have to install bower, etc.
beforehand. cheers!
…On Tue, Jun 5, 2018 at 11:14 Irakli Safareli ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In package.json
<#77 (comment)>:
> @@ -4,6 +4,7 @@
"description": "",
"main": "index.js",
"scripts": {
+ "preinstall": "bower install --production && pulp build -t chanterelle.js",
I think you need postinstall
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#77 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACyqU--ClhUEdMFmg4F9Lc0tJXmiy_6dks5t5ryNgaJpZM4UbMVq>
.
|
|
is this done? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm i -g;)