Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault on reload with progress bar #778

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

mwestphal
Copy link
Contributor

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #778 (7658acc) into master (8b22935) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 7658acc differs from pull request most recent head 44253f6. Consider uploading reports for the commit 44253f6 to get more accurate results

@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
+ Coverage   96.62%   96.69%   +0.06%     
==========================================
  Files         115      115              
  Lines        5776     5777       +1     
==========================================
+ Hits         5581     5586       +5     
+ Misses        195      191       -4     
Impacted Files Coverage Δ
...brary/VTKExtensions/Rendering/vtkF3DRenderPass.cxx 97.10% <100.00%> (ø)
library/src/loader_impl.cxx 100.00% <100.00%> (+2.83%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mwestphal mwestphal requested a review from Meakk April 26, 2023 12:50
library/src/loader_impl.cxx Outdated Show resolved Hide resolved
library/src/loader_impl.cxx Outdated Show resolved Hide resolved
@mwestphal mwestphal merged commit e035ec3 into f3d-app:master Apr 26, 2023
mwestphal added a commit that referenced this pull request Feb 10, 2024
Fix segfault on reload with progress bar
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
Fix segfault on reload with progress bar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reloading a file while using a progress bar causes a segfault
2 participants