Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation instructions yarn-v4 #23

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Installation instructions yarn-v4 #23

merged 3 commits into from
Jan 26, 2024

Conversation

fabOnReact
Copy link
Owner

@fabOnReact fabOnReact commented Jan 26, 2024

fixes #20

@efstathiosntonas
Copy link
Contributor

thanks Fabrizio!

now it throws on patch: 🤔

[!] Unsupported react-native version! (0.73.2) [!] Supported react-native versions: 0.73.0

@fabOnReact
Copy link
Owner Author

fabOnReact commented Jan 26, 2024

Thanks @efstathiosntonas. I will to add support for latest rn version #24 after I complete this PR #19.

Right now, this library only supports 0.73, but there are no limitations to support other versions and add many patches.
I just did not yet start working on this task, but I will start soon.

I'm not patching node_modules, but implementing native APIs based on the ReactNative Android/iOS APIs.
So there will not be issue like merge conflicts when upgrading, as I built new APIs and the upgrading will be similar to how it is done with react-native:

  • creating a new branch (for ex. 0.74)
  • testing the branch, in our case we may have to re-write some of our private APIs, but they are few changes.
  • doing a new release

Thanks a lot for taking the time to test the library. Sorry about the troubleshooting.

@fabOnReact fabOnReact marked this pull request as ready for review January 26, 2024 08:18
@efstathiosntonas
Copy link
Contributor

Thanks for the explanation, no worries about troubleshooting, I understand it's hard to keep up with so many branches involved. Happy to help testing!

@fabOnReact fabOnReact merged commit 689948f into main Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] - yarn patch (version 4.0.2) throws Unknown Syntax Error: Not enough positional arguments.
2 participants