Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center setup menu title patches #1801

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

xemonix0
Copy link
Contributor

The hardcoded positions assume very specific patches, e.g. M_COMPAT is assumed to say "Doom Compatibility" (even though nowadays the alt. text is "Compatibility", and I'd expect a patch saying the exact same in BIGFONT to work perfectly fine) and M_STAT is assumed to say "Status Bar / HUD` (with spaces, unlike the modern alt. text).

What I did (with x == -1 meaning centered) may not be the best way to do it so I expect a change request. Also, I did not center the patches that I think are supposed to be off-center (M_EPISOD, M_NEWG, M_SKILL, M_LOADG, M_SAVEG; looks like they are supposed to be positioned relatively to the items and not the screen, and I feel like they should be kept at their vanilla positions anyways).

@fabiangreffrath
Copy link
Owner

I'd prefer if you could #define M_X_CENTER -1 in some header and use this consistently.

@xemonix0
Copy link
Contributor Author

I'd prefer if you could #define M_X_CENTER -1 in some header and use this consistently.

Done in 2598e52.

Copy link
Owner

@fabiangreffrath fabiangreffrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

What do the others say?

Copy link
Collaborator

@ceski-1 ceski-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

Copy link
Collaborator

@rfomin rfomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@fabiangreffrath fabiangreffrath merged commit 1b3f857 into fabiangreffrath:master Jul 25, 2024
8 checks passed
@xemonix0 xemonix0 deleted the woof_centertitle branch July 25, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants