Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of deprecated flask.ext imports #270

Merged
merged 1 commit into from
Aug 1, 2020

Conversation

foosel
Copy link
Contributor

@foosel foosel commented Jul 14, 2020

flask.ext has been deprecated for years now and should actually have been logging a warning to console ever since too. OctoPrint 1.4.1 had to update the flask dependencies due to security considerations and in the new flask version the old compatibility layer still allowing flask.ext to work got removed.

Which means this plugin no longer will load on OctoPrint 1.4.1+ unless this PR gets merged and a new release (1.5.1?) pushed out.

See also the discussion in OctoPrint/OctoPrint#3638

Closes #269

 flask.ext has been deprecated for years now and has been logging
 a warning to console ever since. OctoPrint 1.4.1 had to update
 the flask dependencies due to security considerations and with the
 new flask version the old compatibility layer still allowing
 flask.ext to work got removed.

 See also the discussion in OctoPrint/OctoPrint#3638

 Closes fabianonline#269
szobov added a commit to szobov/OctoPrint-Telegram that referenced this pull request Jul 28, 2020
Copy link

@louispires louispires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets get this merged please

Copy link

@louispires louispires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets get this merged please

@giloser giloser merged commit d8ef9da into fabianonline:master Aug 1, 2020
@foosel
Copy link
Contributor Author

foosel commented Aug 3, 2020

Sorry having to ping y'all again but I see that while this has been merged, a new release including it hasn't been cut yet. I currently plan to push out OctoPrint 1.4.1 out tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OctoPrint-Telegram fails with OctoPrint 1.4.1rc2
3 participants