Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashing does not work with IE9 #14

Open
arabold opened this issue Dec 13, 2013 · 8 comments
Open

Dashing does not work with IE9 #14

arabold opened this issue Dec 13, 2013 · 8 comments

Comments

@arabold
Copy link
Contributor

arabold commented Dec 13, 2013

Not much to add to the description. There're a couple of issues with IE9 support - for example EventSource is not supported and requires a Polyfill, and the CSS seems to be broken and not working.

I'm working on a patch right now. This task is for tracking and notifying you about the efforts and progress.

@fabiocaseri
Copy link
Owner

Yes, I never tested with IE because AFAIK it doesn't support Server-Sent Events and I can use chrome on my wall screen.
Ok, thanks!

@adrianlee
Copy link

I used https://github.com/Yaffle/EventSource/ polyfill to get the SSE working. CSS seem to be fine but no data seems to be displayed on the widgets. I'm also looking into this issue. @arabold any progress?

@arabold
Copy link
Contributor Author

arabold commented Dec 20, 2013

That's basically as far as I came, too. But I'm trying to dig deeper into it today and can hopefully submit a pull-request soon.

@adrianlee
Copy link

I got to familiarize myself with the IE dev tools. Do you have any idea if it's the dashing js or or batman?

@arabold
Copy link
Contributor Author

arabold commented Dec 20, 2013

It doesn't load the html of the widgets. I'm digging through the code right now... somewhat hard for me to understand the logic as I'm new to most of the modules used.

@arabold
Copy link
Contributor Author

arabold commented Dec 20, 2013

Okay, found it. this.constructor.name doesn't exist in IE and returns an undefined. This makes everything else fail badly. I'll submit a pull-request as soon as I got everything cleaned up again.

@arabold
Copy link
Contributor Author

arabold commented Dec 20, 2013

Here you go: #15 -- probably you should test that yourself, @adrianlee.

@fjorgemota
Copy link

@fabiocaseri What about using socket.io for get this compatibility? (it seems great for something like a dashboard, but it may need to refactor some core parts of the project, too)

alexschwartz pushed a commit to alexschwartz/dashing-js that referenced this issue Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants