Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portrait 3 works as well #171

Merged
merged 1 commit into from
Mar 27, 2022
Merged

Portrait 3 works as well #171

merged 1 commit into from
Mar 27, 2022

Conversation

maclomhair
Copy link
Contributor

I just tried the extension with the portrait 3 and it seems to work quite well. I haven't tested thoroughly, though.

(Also this fixes a small typo in the "Supported Devices" heading)

@miggland
Copy link

I disagree - since setting the depth of the autoblade does not work by default.

When sending the command
dev.send_command(tool.depth(1))
manually, it works.

It seems this is because the Product ID is not in 'PRODUCT_LINE_CAMEO3_ON' and thus the command is not sent during setup.

The Product ID on my Portrait 3 seems to be 4410 (0x113a)

@t0b3
Copy link
Collaborator

t0b3 commented Feb 13, 2022

@maclomhair @miggland thanks a lot for your contribution. I will happily add new hardware to the list.
Before we add it I would like you to help in adding the device to

and help out with testing whether it shall belong to a list (i.e. CAMEO3_ON or what else) to ensure the right commands are triggered.
Thanks a lot for your tests in advance as I don't have any such device.

@miggland
Copy link

Well, I can give you this straight away:

Bus 001 Device 006: ID 0b4d:113a Graphtec America, Inc.

It has an autoblade, only one tool holder.

This works fine:
tool = SilhouetteCameoTool(1) dev = SilhouetteCameo() dev.send_command(tool.depth(1)) dev.send_command(tool.depth(5)) dev.send_command(tool.depth(10))

I'm not sure what else I'm supposed to test (haven't noticed anything else not working so far..)

@t0b3
Copy link
Collaborator

t0b3 commented Feb 14, 2022

I'd like to receive a patch which adds PRODUCT_ID_SILHOUETTE_PORTRAIT3 definition and specific case handling (if/else ...) for your device.

@mikhailmihalkov
Copy link

Tried to run Silhouette Portrait 3 and it does not work on win7-10 and linux blade makes 1 pass and in 2-3 seconds stops... Apparently, the firmware was changed in the new model and the python code is not suitable... Who has a point?

@t0b3
Copy link
Collaborator

t0b3 commented Feb 18, 2022

@mikhailmihalkov thanks a lot for your feedback. I guess this will help. Did you try --force_hardware with any modern Silhouette Plotter?

@mikhailmihalkov
Copy link

log 1 and log 2 is a square cutting from Silhouette Studio Portrait 3

@mikhailmihalkov
Copy link

@mikhailmihalkov
Copy link

Result dump - wireshark usb dump
usb_dump_Silhouette Portrait3.zip

@mikhailmihalkov
Copy link

@mikhailmihalkov thanks a lot for your feedback. I guess this will help. Did you try --force_hardware with any modern Silhouette Plotter?
https://github.com/mossblaser/py_silhouette/tree/master/test I checked with this library portrait 3 and it works passes the test successfully

@t0b3
Copy link
Collaborator

t0b3 commented Feb 27, 2022

@mikhailmihalkov what according to your tests needs to be adapted in https://github.com/fablabnbg/inkscape-silhouette/blob/5a19eb4526d96371ff61683aa6e31f5bf6c5c537/silhouette/Graphtec.py in order to work properly? your PR is welcome...

@ktosiek ktosiek mentioned this pull request Mar 27, 2022
@t0b3 t0b3 merged commit fd63eb2 into fablabnbg:master Mar 27, 2022
@ktosiek
Copy link
Contributor

ktosiek commented Mar 28, 2022

I can confirm Portrait 3 mostly works without additional changes, but to get AutoBlade working you'll also need my PR: #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants