remove unused "private" libusb. #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can someone confirm things continue to work on windows and macos as well?
feel free to contribute to the installation steps in case it needs some love... |
|
@jnweiger any objections if we remove internal pyusb? |
|
@simon-budig may I ask you to update this PR to equally drop the internal pyusb references from
|
Since we depend on python3-usb now there is no need to ship our own copy of libusb. Get rid of it.
simon-budig
force-pushed
the
remove-libusb
branch
from
f58318d
to
aed9bec
Compare
@t0b3 I recently set this up on somebody's macOS M1 laptop. Can confirm that this branch worked after rebasing to latest |
|
@antonok-edm 👍 good to know - can you (or someone) give any indication about windows? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we depend on python3-usb now there is no need to ship our own copy
of libusb. Get rid of it.