Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Test printing unicode characters #3563

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Conversation

dbrattli
Copy link
Collaborator

@dbrattli dbrattli commented Oct 22, 2023

  • Print unicode character to make sure printing does not blow up
  • Code cleanup and formatting

@TheAngryByrd
Copy link

Well one thing I just noticed is there doesn't seem to be any python tests actually running on the windows runs

image

@MangelMaxime
Copy link
Member

If they don't run there are no errors, so it means that it works 😏

More seriously, I have PR testing a fix for the Python tests on windows here #3569

Waiting for it to run and will merge it if all is fine.

@MangelMaxime
Copy link
Member

I rebased this PR to the latest version of main which as the CI fix in it.

@TheAngryByrd
Copy link

While it doesn't show the character it doesn't seem to blow up. Puzzling.

@MangelMaxime
Copy link
Member

I think it could be interesting to check if this is also the case when running it on a local Windows machine with different terminals like Cmd, Windows Terminal, Git bash, etc.

Just to check if this is not just a problem of encoding based on the terminal used by the CI

@dbrattli dbrattli merged commit aa9eef5 into main Oct 28, 2023
14 checks passed
@dbrattli dbrattli deleted the python-print-unicode branch October 28, 2023 05:58
@MangelMaxime
Copy link
Member

@dbrattli Which formatter are you using for Python code?

This is so I can install it on my machine too when contributing to the python code.

@dbrattli
Copy link
Collaborator Author

dbrattli commented Nov 15, 2023

@MangelMaxime I'm using ruff format, https://github.com/astral-sh/ruff#usage. I've btw added it so it formats the files in the generated fable-library in temp.

@MangelMaxime
Copy link
Member

Ok thank you @dbrattli.

I think one of the next thing I want to add to the repo is auto format of the different source code when possible, just so we all write the same things. And it will also clean up some of the files who use odd formatting rules

@dbrattli
Copy link
Collaborator Author

@MangelMaxime I'll open an issue on this topic so we can discuss more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants