Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extraneous dollar sign in py format string #3878

Merged
merged 2 commits into from
Sep 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Fable.Cli/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

### Changed

* [Python] Remove `$` sign when reporting an error from `assert_equal` and `assert_not_equal` (#3878) (by @joprice)

## 4.20.0 - 2024-09-04

### Added
Expand Down
2 changes: 1 addition & 1 deletion src/fable-library-py/fable_library/reflection.py
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ def get_enum_case(t: TypeInfo, v: int | str) -> EnumCase:
if kv[0] == v:
return kv

raise ValueError(f"{v}' was not found in ${t.fullname}")
raise ValueError(f"{v}' was not found in {t.fullname}")

for kv in t.enum_cases:
if kv[1] == v:
Expand Down
4 changes: 2 additions & 2 deletions src/fable-library-py/fable_library/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -355,12 +355,12 @@ def clamp(comparer: Callable[[_T, _T], int], value: _T, min: _T, max: _T):

def assert_equal(actual: Any, expected: Any, msg: str | None = None) -> None:
if not equals(actual, expected):
raise Exception(msg or f"Expected: ${expected} - Actual: ${actual}")
raise Exception(msg or f"Expected: {expected} - Actual: {actual}")


def assert_not_equal(actual: _T, expected: _T, msg: str | None = None) -> None:
if equals(actual, expected):
raise Exception(msg or f"Expected: ${expected} - Actual: ${actual}")
raise Exception(msg or f"Expected: {expected} - Actual: {actual}")


MAX_LOCKS = 1024
Expand Down
Loading