Properly exit when receiving SIGINT/SIGTERM/SIGHUP
#377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #322
Currently,
rubyfmthas no concept of signal handling, and while it's theoretically so fast it shouldn't matter, there are times where it can hang or run for very long times (e.g. running in debug mode on gigantic files) where users may want to kill it. This PR uses thectrlccrate to just exit when receiving any ofSIGINT/SIGTERM/SIGHUPfrom the OS.There may be more graceful ways to handle this (like setting a variable and then checking it at certain places in the program), but just exiting gets us 99% of the value here with far less invasive changes.