Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.27.2] portPropertyFile not written anymore #1112

Closed
mixaaaa opened this issue Oct 12, 2018 · 5 comments · Fixed by #1248
Closed

[0.27.2] portPropertyFile not written anymore #1112

mixaaaa opened this issue Oct 12, 2018 · 5 comments · Fixed by #1248
Assignees

Comments

@mixaaaa
Copy link

mixaaaa commented Oct 12, 2018

Description

After upgrading to newer d-m-p version (0.26.1 -> 0.27.2) the portPropertyFile-property is not working anymore. By checking change logs and issues we did not really found an explanation why this failure happens. We used following standard configuration.

<configuration>
    <portPropertyFile>${project.basedir}/src/test/resources/ports.properties</portPropertyFile>
    <images>
        <image>
            <name>test-db</name>
            <registry>vm-test:443</registry>
            <alias>dockerfile</alias>
            <build>
                <dockerFileDir>${project.basedir}/src/test/docker</dockerFileDir>
            </build>
            <run>
                <ports>
                    <port>host.port:5432</port>
                </ports>
                <wait>
                    <time>5000</time>
                </wait>
            </run>
        </image>
    </images>
</configuration>

Thanks in advance,
Uwe

Info

  • d-m-p version : 0.26.1 -> 0.27.2
  • Maven version (mvn -v) : Apache Maven 3.3.9
  • Docker version :
Client:
 Version:      17.05.0-ce
 API version:  1.29
 Go version:   go1.7.5
 Git commit:   89658be
 Built:        Thu May  4 22:04:27 2017
 OS/Arch:      linux/amd64

Server:
 Version:      17.05.0-ce
 API version:  1.29 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   89658be
 Built:        Thu May  4 22:04:27 2017
 OS/Arch:      linux/amd64
 Experimental: false
  • If it's a bug, how to reproduce :
    just change the version ;)
@rhuss
Copy link
Collaborator

rhuss commented Oct 12, 2018

Thanks for the report, really looks like a regression. I'm trying to jump on that asap.

@JesperTerkelsen
Copy link

👍

@vap78
Copy link

vap78 commented Jul 18, 2019

Hi

any update here? This is still an issue in 0.30.0.

Best regards
Vasil

@rhuss
Copy link
Collaborator

rhuss commented Jul 23, 2019

Nope, not yet. Sorry. @rohanKanojia do you have some spare cycles to look into this ?

@rohanKanojia
Copy link
Member

oh, okay. Let me try to look into this.

@rohanKanojia rohanKanojia self-assigned this Jul 23, 2019
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Jul 27, 2019
port mappings should be written after we start containers.
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Jul 27, 2019
port mappings should be written after we start containers.
rhuss pushed a commit that referenced this issue Jul 28, 2019
* Fix #1112: portPropertyFile not written anymore

port mappings should be written after we start containers.

* Update changelog.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants