-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NullPointerException after upgrading to 0.29.0 #1200
Comments
@papegaaij : Oh 😞 , apologies for the inconvenience caused. could you please share a sample pom with which I can reproduce this issue? |
@papegaaij : What is your configuration? Could you please share? Are you using any dockerfile while building? |
Fixed my mistake.
Fixed my mistake.
@papegaaij : Hi, I tried a bunch of samples but could not reproduce your issue. I've raised #1202 with possible suspicion. Could you please share a pom with which you reproduced this issue? If you don't want to share pom(in case of closed source). You can make up some similar dummy project reproducing the issue. |
+1 same here |
@sylvainmouquet : Hi, Could you please share a sample pom with which I can reproduce this ??? |
I've created a very simple project that triggers the NPE: https://github.com/papegaaij/maven-docker-npe Downgrading to 0.28.0 fixes the error. |
Thanks ! @rohanKanojia Its that the |
okay, let me confirm it(to stay safe) then I'll update PR |
Fixed my mistake.
@papegaaij : Okay, so I tested it with your fix and NullPointerException was resolved. But there was some other error:
|
Fixed my mistake.
Fixed my mistake.
This file does exist in the repository and with 0.28.0 it is found, so this is a regression. |
Yes, indeed. Looks like the context directory is not set properly to point to the dir containing this sql file. |
ah, okay. let me check 😞 |
Fixed my mistake.
BuildImageConfiguration is not aware of the source directory( docker-maven-plugin/src/main/java/io/fabric8/maven/docker/assembly/DockerAssemblyManager.java Line 118 in adc22e7
During adding contextDir support we've changed DefaultFileSet initialization to initialize from contextDir instead of that dockerFile that was generated above. |
According to the docs:
|
Fixed my mistake.
Description
After upgrading from 0.28.0 to 0.29.0 we get the folloing NullPointerException when trying to build a docker image:
Other than the version, we did not change any configuration.
Info
mvn -v
) :The text was updated successfully, but these errors were encountered: