Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Integration tests #1201

Closed
rohanKanojia opened this issue Apr 10, 2019 · 0 comments · Fixed by #1209
Closed

Add Support for Integration tests #1201

rohanKanojia opened this issue Apr 10, 2019 · 0 comments · Fixed by #1209

Comments

@rohanKanojia
Copy link
Member

I think we need tests that should run against a real docker daemon(since that's mostly what this plugin is used for) with various configuration cases. So that we can avoid breaking plugin's standard behavior again and again.

These tests don't need to be a part of this PR test suite(not sure how many cases can we check there on CI), but they can be something we can run before/after merging big PRs or doing releases. Also, it can catch the mistakes of new people like me who can potentially break plugin.
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 13, 2019
@rohanKanojia
Fix fabric8io#1201: Initial draft for integration tests
b8fbc43
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 13, 2019
@rohanKanojia
Fix fabric8io#1201: Initial draft for integration tests
e83d20f
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 13, 2019
@rohanKanojia
Fix fabric8io#1201: Initial draft for integration tests
3513742
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 13, 2019
@rohanKanojia
Fix fabric8io#1201: Initial draft for integration tests
fb4373f
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 13, 2019
@rohanKanojia
Fix fabric8io#1201: Initial draft for integration tests
a08868c
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 13, 2019
@rohanKanojia
Fix fabric8io#1201: Initial draft for integration tests
bb67bd8
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 13, 2019
@rohanKanojia
Fix fabric8io#1201: Initial draft for integration tests
0ab355a
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 13, 2019
@rohanKanojia
Fix fabric8io#1201: Initial draft for integration tests
4dbc12d
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 13, 2019
@rohanKanojia
Fix fabric8io#1201: Initial draft for integration tests
0623c8e
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 13, 2019
@rohanKanojia
Fix fabric8io#1201: Initial draft for integration tests
810b8d8
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 13, 2019
@rohanKanojia
Fix fabric8io#1201: Initial draft for integration tests
cac622b
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 13, 2019
@rohanKanojia
Fix fabric8io#1201: Initial draft for integration tests
955105c
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 13, 2019
@rohanKanojia
Fix fabric8io#1201: Initial draft for integration tests
6d2d724
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 13, 2019
@rohanKanojia
Fix fabric8io#1201: Initial draft for integration tests
593f769
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 13, 2019
@rohanKanojia
Fix fabric8io#1201: Initial draft for integration tests
f250ee1
@rohanKanojia rohanKanojia mentioned this issue Apr 13, 2019
Merged
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 13, 2019
@rohanKanojia
Fix fabric8io#1201: Initial draft for integration tests
652847c
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Aug 16, 2019
@rohanKanojia
Fix fabric8io#1201: Initial draft for integration tests
b93c1c3
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Oct 10, 2019
@rohanKanojia
Fix fabric8io#1201: Initial draft for integration tests
4b3179e
rhuss added a commit that referenced this issue Jan 8, 2020
@rohanKanojia @rhuss
Fix #1201: Initial draft for integration tests (#1209)
3085953 
* Fix #1201: Initial draft for integration tests

* Pick version from main plugin module and modify test version accordingly

Co-authored-by: Roland Huß <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1201: Initial draft for integration tests rohanKanojia/docker-maven-plugin
1 participant
@rohanKanojia