Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slow compression in docker:save #1205

Closed
wrosenuance opened this issue Apr 12, 2019 · 0 comments
Closed

Slow compression in docker:save #1205

wrosenuance opened this issue Apr 12, 2019 · 0 comments

Comments

@wrosenuance
Copy link
Contributor

Description

Compression of saved images is performed by the plugin and performs poorly when gzip is used.

Info

The code uses default buffer sizes (8K for copying, 512 bytes for gzip codec) and the default compression level (slowest, but with the smallest output).

Per JDK-8142920, a compression level of 3 is a better balance than the default, running almost twice as fast. Adding in larger buffer sizes led to a significant performance boost for me: for a ~500MB archive that downloads without compression in 54s, it was taking 160s to compress, yielding an ~150MB. Switching to compression level 3 and increasing the buffers to just 64k took the compression time down to 65s and only increased the size to ~163MB.

  • d-m-p version : 0.29-SNAPSHOT
  • Maven version (mvn -v) : 3.5.4
wrosenuance added a commit to wrosenuance/docker-maven-plugin that referenced this issue Apr 12, 2019
@wrosenuance
Issue fabric8io#1205 Increase GZIP compression speed for docker:save.
2e23ca4 
Signed-off-by: William Rose <[email protected]>
wrosenuance added a commit to wrosenuance/docker-maven-plugin that referenced this issue Apr 12, 2019
@wrosenuance
Issue fabric8io#1205 Increase GZIP compression speed for docker:save.
6ff1560 
Signed-off-by: William Rose <[email protected]>
rhuss pushed a commit that referenced this issue Apr 12, 2019
@wrosenuance @rhuss
Issue #1205 Increase GZIP compression speed for docker:save. (#1206)
adc22e7 
* Issue #1203 NPE if docker:save called with filename only.

Signed-off-by: William Rose <[email protected]>

* Issue #1205 Increase GZIP compression speed for docker:save.

Signed-off-by: William Rose <[email protected]>
wrosenuance added a commit to wrosenuance/docker-maven-plugin that referenced this issue Apr 12, 2019
@wrosenuance
Issue fabric8io#1205 Make constants for buffer sizes.
38a7cb7 
Signed-off-by: William Rose <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wrosenuance