Fix #1201: Initial draft for integration tests #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
force-pushed
the
pr/integration-tests
branch
from
f250ee1
to
652847c
Compare
|
Cool, thanks ! Totally overlooked that PR. Awesome work, @rohanKanojia. Unfortunately the test fails, if you have some spare, could give it a look again ? |
|
seems like maybe samples' dmp version is outdated. Let me try to update it tomorrow or maybe monday. |
rohanKanojia
force-pushed
the
pr/integration-tests
branch
3 times, most recently
from
0ea448a
to
22ffcd0
Compare
rohanKanojia
force-pushed
the
pr/integration-tests
branch
from
22ffcd0
to
07d0c54
Compare
rohanKanojia
force-pushed
the
pr/integration-tests
branch
from
07d0c54
to
1034c59
Compare
rhuss
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1201
I didn't have to do much as I just picked some of the working samples and added some executions into some of the poms. We can remove projects you feel are redundant and add some other poms in order to test important workflows. I've mostly added executions of
build,startandstopgoals, but we can add others too.