Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI builds with Maven Wrapper to ensure that Maven Wrapper files and configuration are correct #1450

Closed
mabrarov opened this issue Apr 1, 2021 · 0 comments · Fixed by #1451
Closed

CI builds with Maven Wrapper to ensure that Maven Wrapper files and configuration are correct #1450

mabrarov opened this issue Apr 1, 2021 · 0 comments · Fixed by #1451

Comments

@mabrarov
Copy link
Contributor

mabrarov commented Apr 1, 2021 •
edited
Loading

Description

Add automatic builds with Maven Wrapper into CI.

Info

  • docker-maven-plugin version : 0.34-SNAPSHOT
  • Maven version (mvn -v) : n/a
  • Docker version : n/a
  • If it's a bug, how to reproduce : n/a
  • If it's a feature request, what is your use case : when working on Copy goal for copying files from container to host #1405, I found than Maven Wrapper files were broken (maybe wrong line ending), so I suggest to use build matrix in CircleCI and duplicate builds using mvn command with builds using ./mvnw (for Linux builds) and mvnw.cmd (for Windows builds) to ensure that Maven Wrapper works correctly. Note that Maven Wrapper caches its files under ~/.m2/wrapper, so the builds will need to ensure that this directory doesn't exist (i.e. remove this directory if it exists) before calling Maven Wrapper.
  • Sample project : n/a
@mabrarov mabrarov mentioned this issue Apr 1, 2021
Merged
3 tasks
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 1, 2021
@rohanKanojia
Fix fabric8io#1450: CI builds with Maven Wrapper to ensure that Maven…
53bc7da 
… Wrapper files and configuration are correct

+ Add Linux and Windows Github workflows for maven wrapper builds
+ Updated maven wrapper files as per maven 3.6.3
@rohanKanojia rohanKanojia mentioned this issue Apr 1, 2021
Merged
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 1, 2021
@rohanKanojia
Fix fabric8io#1450: CI builds with Maven Wrapper to ensure that Maven…
4ade096 
… Wrapper files and configuration are correct

+ Add Linux and Windows Github workflows for maven wrapper builds
+ Updated maven wrapper files as per maven 3.6.3
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 2, 2021
@rohanKanojia
Fix fabric8io#1450: CI builds with Maven Wrapper to ensure that Maven…
588a921 
… Wrapper files and configuration are correct

+ Add Linux and Windows Github workflows for maven wrapper builds
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 2, 2021
@rohanKanojia
Fix fabric8io#1450: CI builds with Maven Wrapper to ensure that Maven…
b9742a2 
… Wrapper files and configuration are correct

+ Add Linux and Windows Github workflows for maven wrapper builds
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue May 15, 2021
@rohanKanojia
Fix fabric8io#1450: CI builds with Maven Wrapper to ensure that Maven…
f7ff36a 
… Wrapper files and configuration are correct

+ Add Linux and Windows Github workflows for maven wrapper builds
rohanKanojia added a commit that referenced this issue May 15, 2021
@rohanKanojia
Fix #1450: CI builds with Maven Wrapper to ensure that Maven Wrapper …
34ea02e 
…files and configuration are correct

+ Add Linux and Windows Github workflows for maven wrapper builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mabrarov