Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Risk for large Image Layer due to chown #336

Closed
Khazrak opened this issue Nov 20, 2015 · 1 comment
Closed

Risk for large Image Layer due to chown #336

Khazrak opened this issue Nov 20, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@Khazrak
Copy link

Khazrak commented Nov 20, 2015

If the base directory for you assembly contains files and you use in then it will chown -R the whole directory. So if you have a server in that directory and the assembly just copies in config then the whole server-directory will be chown:ed. This means that all the files have been changed in that Image Layer and is added to the Image size.

Don't know if this will be optimized or not, but it's probably good for users to know.

The only solution I can think of is copying the files to /tmp/folder, chown -R that folder and then move it to the target destination

@rhuss
Copy link
Collaborator

rhuss commented Nov 30, 2015

Completely agreed that there is a gotcha when not using an empty directory as basedir. I implemented your suggestion for 0.13.7

Just to be sure: That happens for you when you are using a <user> in the assembly configuration, right ?

@rhuss rhuss added this to the 0.13.7 milestone Nov 30, 2015
@rhuss rhuss added the fixed label Nov 30, 2015
@rhuss rhuss self-assigned this Dec 2, 2015
@rhuss rhuss closed this as completed in 8df9236 Dec 7, 2015
leusonmario pushed a commit to leusonmario/docker-maven-plugin that referenced this issue Aug 18, 2018
Make README notice about future bigger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants