Different configuration for run and build via PropertyConfigHandler #386
Labels
Comments
|
You are right that's unfortunate. Its a good idea to introduce a more specific level which, when used, takes precedence over the the less specific property (without I don't when having time to implement this but would happily integrate a pull request for this. |
stromnet
added a commit
to stromnet/docker-maven-plugin
that referenced
this issue
Feb 12, 2018
Addresses fabric8io#386. Note that it was not possible to use "env.run/build", which would have matched well with other properties, because we already have the "env" matcher (which would have matched env.run too, injecting bad properties).
stromnet
added a commit
to stromnet/docker-maven-plugin
that referenced
this issue
Feb 14, 2018
Addresses fabric8io#386. Note that it was not possible to use "env.run/build", which would have matched well with other properties, because we already have the "env" matcher (which would have matched env.run too, injecting bad properties). Signed-off-by: Johan Ström <[email protected]>
stromnet
added a commit
to stromnet/docker-maven-plugin
that referenced
this issue
Mar 18, 2018
Addresses fabric8io#386. Note that it was not possible to use "env.run/build", which would have matched well with other properties, because we already have the "env" matcher (which would have matched env.run too, injecting bad properties). Signed-off-by: Johan Ström <[email protected]>
|
Fixed with #948 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The handler currently uses some properties for both build and run configuration, for example docker.env.VARIABLE. I need to set an env value for runtime (integration test) that I don't want to be in the docker container. As far as I see, this is currently not possible.
Proposal: Introduce two other sets of properties (docker.run.x and docker.build.x) to be able to configure them differently.
The text was updated successfully, but these errors were encountered: