-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature request: Add support for a containerId property #412
Comments
IMO that makes sense, maybe we can make it a bit more generic, too (don't like long property names so much ;-) My suggestion would be <run>
<defineProperties>
<containerId>myPropertyName</containerId>
<!-- Maybe later other meta data like the "name" or "startDate", stuff which
is available from "docker inspect" -->
</defineProperties>
</run> We could also implicitly set properties after some conventions like wdyt ? |
The variant with the defineProperties tag sounds good to me. |
Please add a property "containderId" to the list of specific properties which are exposed as Maven properties. E.g.: "docker.container.tomcat.containerId". See also https://fabric8io.github.io/docker-maven-plugin/docker-start.html |
Sorry, forgot this issue. will be available in the next release. |
Ups, got your answer to late. Already send a pull request. |
No problem. The release is underway, you will be able to use 0.15.5 in about half an hour. |
Thanks a lot! |
Please add a configuration option for the goal docker:start to provide a maven project property name the containerId is stored into. I'd like to run some integration tests using docker-java client with the container setup done by the docker-maven-plugin.
E.g. in the configurations's run section a new tag containerIdProperty:
The maven project property containerId will contain the id of the new generated container. This property can now be used in the maven-failsafe-plugin to pass the containerId to Java.
The text was updated successfully, but these errors were encountered: