Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging regression, exta newline #538

Closed
jgangemi opened this issue Aug 14, 2016 · 3 comments
Closed

logging regression, exta newline #538

jgangemi opened this issue Aug 14, 2016 · 3 comments

Comments

@jgangemi
Copy link
Collaborator

getting this output w/ 0.15.16

rest-website-api> !!             -XX:+UseG1GC

rest-website-api> !!             -XX:+UseStringDeduplication

rest-website-api> !!             -XX:+HeapDumpOnOutOfMemoryError

rest-website-api> !!             -Dcom.sun.management.jmxremote.port=8585

rest-website-api> !!             -Dcom.sun.management.jmxremote.rmi.port=8585

rest-website-api> !!             -Djava.rmi.server.hostname=docker.local

rest-website-api> !!             -Dcom.sun.management.jmxremote.ssl=false

rest-website-api> !!             -Dcom.sun.management.jmxremote.authenticate=false
@rhuss
Copy link
Collaborator

rhuss commented Aug 14, 2016

Sorry, found that, too. I'm not sure whether it is really our fault, since
we haven't changed any thing here. I suspect some change in the docker api.
Whatever, I already fixed that locally, but apparently I forgot to push
before I left off to PTO. Fix is trivial, just trim a trailing newline
before printing out the logline.

Will push that next week..

Jae Gangemi [email protected] schrieb am So., 14. Aug. 2016, 18:19:

getting this output w/ 0.15.16

rest-website-api> !! -XX:+UseG1GC

rest-website-api> !! -XX:+UseStringDeduplication

rest-website-api> !! -XX:+HeapDumpOnOutOfMemoryError

rest-website-api> !! -Dcom.sun.management.jmxremote.port=8585

rest-website-api> !! -Dcom.sun.management.jmxremote.rmi.port=8585

rest-website-api> !! -Djava.rmi.server.hostname=docker.local

rest-website-api> !! -Dcom.sun.management.jmxremote.ssl=false

rest-website-api> !! -Dcom.sun.management.jmxremote.authenticate=false


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#538, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGDCO75weoR-5jOmWMWgYH1C2hBOumZks5qf0AUgaJpZM4Jj7hm
.

@jgangemi
Copy link
Collaborator Author

hrm - prior to that for this project i was using 0.15.11 - my co-worker has also reported there seems to be a bug in container resolution which i have been meaning to investigate but haven't had a chance to yet. hopefully this week.

either way, no worries - not the end of the world. enjoy your vacation!

@rhauch
Copy link

rhauch commented Aug 15, 2016

This extra line feed appears for me with 0.15.14, but 0.15.13 is fine with the same project build system. BTW, it seems like blank log lines don't have the extra line feed, while any non-zero-length log line gets an extra line feed.

@rhuss rhuss closed this as completed in d49e82c Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants