Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entrypoint does not support arguments #84

Closed
jamesnetherton opened this issue Feb 3, 2015 · 2 comments
Closed

Entrypoint does not support arguments #84

jamesnetherton opened this issue Feb 3, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@jamesnetherton
Copy link

Unless I'm missing something obvious, entrypoint does not seem to support arguments. For example if I configure the plugin like the following:

<configuration>
  <images>
    <image>
      <name>ubuntu</name>
      <alias>test-container</alias>
      <run>
        <entrypoint>/bin/echo hello world</entrypoint>
      </run>
    </image>
  </images>
</configuration>

The build fails with:

[ERROR] Failed to execute goal org.jolokia:docker-maven-plugin:0.11.0:start (start-containers) on project docker-maven-plugin-entrypoint: Error while calling docker: Starting container with id 3e9420f4ff87b0213147eb165ab021b2889943ecf4fe0bb4d8f114b616b946fa (Not Found: 404)

However , the build runs fine if I remove the arguments from entrypoint. Not sure if this is intentional but entrypoint should support arguments just like the normal command configuration.

I've fixed this on my fork in this commit 63f8165. If you're happy to accept a PR, let me know.

@rhuss
Copy link
Collaborator

rhuss commented Feb 3, 2015

Yes, you are right. I will going to fix that for the next release and copy over your fix directly into the integration branch (if you don't mind) . So no need for a PR.

Thanks ...

@jamesnetherton
Copy link
Author

Yes, no problem. Thanks!

@rhuss rhuss self-assigned this Feb 3, 2015
@rhuss rhuss added this to the 0.11.1 milestone Feb 3, 2015
@rhuss rhuss added the bug label Feb 3, 2015
@rhuss rhuss closed this as completed in d8ba393 Feb 14, 2015
leusonmario pushed a commit to leusonmario/docker-maven-plugin that referenced this issue Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants