feature: Use log prefix as format #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepperbot
reviewed
Nov 4, 2017
| throw new IllegalArgumentException(String.format("No image name format element '%%%s' known", what) ); | ||
| } | ||
| String val = lookup.lookup(); | ||
| return String.format("%" + (options != null ? options : "") + "s",val); |
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #890 +/- ##
============================================
+ Coverage 50.7% 50.84% +0.14%
- Complexity 1203 1208 +5
============================================
Files 139 140 +1
Lines 7106 7123 +17
Branches 953 953
============================================
+ Hits 3603 3622 +19
Misses 3189 3189
+ Partials 314 312 -2
|
Codecov Report
@@ Coverage Diff @@
## master #890 +/- ##
============================================
+ Coverage 50.7% 50.84% +0.14%
- Complexity 1203 1208 +5
============================================
Files 139 140 +1
Lines 7106 7123 +17
Branches 953 953
============================================
+ Hits 3603 3622 +19
Misses 3189 3189
+ Partials 314 312 -2
|
This replaces fabric8io#876 as its a bit more flexible and does not require a new configuration option. You can use now a prefix `%z` for an empty string
rhuss
force-pushed
the
pr/prefix-format
branch
from
69439a1
to
6aefd0a
Compare
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #876 as its a bit more flexible and does not require a new configuration option.
You can use now a prefix
%zfor an empty string