Allow logging prefix to be disabled #876
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new "disablePrefix" option to the log configuration that will cause container logs to be presented without a prefix. Signed-off-by: Scott Coplin <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #876 +/- ##
============================================
+ Coverage 50.46% 50.51% +0.05%
- Complexity 1180 1183 +3
============================================
Files 137 137
Lines 7033 7045 +12
Branches 935 936 +1
============================================
+ Hits 3549 3559 +10
- Misses 3177 3178 +1
- Partials 307 308 +1
|
rhuss
added a commit
to rhuss/docker-maven-plugin
that referenced
this pull request
Nov 4, 2017
This replaces fabric8io#876 as its a bit more flexible and does not require a new configuration option. You can use now a prefix `%z` for an empty string
|
Since I'm not super keen to introduce an extra option only for disabling the prefix, I allowed now to use parameters in the prefix. See #890 for the corresponding PR. For your use case, just use |
rhuss
added a commit
to rhuss/docker-maven-plugin
that referenced
this pull request
Nov 4, 2017
This replaces fabric8io#876 as its a bit more flexible and does not require a new configuration option. You can use now a prefix `%z` for an empty string
|
Yup, that works just fine too. Tried it out on the v0.23.0 tag and behaved just fine. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new "disablePrefix" option to the log configuration that will
cause container logs to be presented without a prefix.
Signed-off-by: Scott Coplin [email protected]