Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent docker:save failing when no images are defined. #1196

Merged
merged 2 commits into from
Apr 9, 2019
Merged

Prevent docker:save failing when no images are defined. #1196

merged 2 commits into from
Apr 9, 2019

Conversation

rhuss
Copy link
Collaborator

@rhuss rhuss commented Apr 9, 2019 •
edited
Loading

Followup and refactoring of #1194 // @wrosenuance

@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #1196 into master will increase coverage by 0.16%.
The diff coverage is 42.85%.

@@             Coverage Diff              @@
##             master    #1196      +/-   ##
============================================
+ Coverage     52.82%   52.98%   +0.16%     
- Complexity     1511     1524      +13     
============================================
  Files           150      150              
  Lines          7974     7982       +8     
  Branches       1200     1201       +1     
============================================
+ Hits           4212     4229      +17     
+ Misses         3348     3332      -16     
- Partials        414      421       +7
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/io/fabric8/maven/docker/SaveMojo.java 25% <42.85%> (+25%) 12 <7> (+12) ⬆️
...va/io/fabric8/maven/docker/AbstractDockerMojo.java 3.09% <0%> (+1.03%) 3% <0%> (+1%) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Apr 9, 2019 •
edited
Loading

Codecov Report

Merging #1196 into master will increase coverage by 0.16%.
The diff coverage is 42.85%.

@@             Coverage Diff              @@
##             master    #1196      +/-   ##
============================================
+ Coverage     52.82%   52.98%   +0.16%     
- Complexity     1511     1524      +13     
============================================
  Files           150      150              
  Lines          7974     7982       +8     
  Branches       1200     1201       +1     
============================================
+ Hits           4212     4229      +17     
+ Misses         3348     3332      -16     
- Partials        414      421       +7
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/io/fabric8/maven/docker/SaveMojo.java 25% <42.85%> (+25%) 12 <7> (+12) ⬆️
...va/io/fabric8/maven/docker/AbstractDockerMojo.java 3.09% <0%> (+1.03%) 3% <0%> (+1%) ⬆️

@rhuss
Copy link
Collaborator Author

rhuss commented Apr 9, 2019

If you agree with the changes, I would merge this PR and close #1194 .

@rhuss rhuss mentioned this pull request Apr 9, 2019
Closed
wrosenuance
wrosenuance approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@wrosenuance wrosenuance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@rhuss
Copy link
Collaborator Author

rhuss commented Apr 9, 2019

@wrosenuance cool, thanks !

@rhuss rhuss merged commit 65109ef into fabric8io:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrosenuance wrosenuance wrosenuance approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhuss @wrosenuance