Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE when cacheFrom is missing from config #1274 #1275

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

travishaagen
Copy link
Contributor

No description provided.

@travishaagen
Copy link
Contributor Author

@rohanKanojia not sure what is wrong with your sonar build

[ERROR] Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.7.0.1746:sonar (default-cli) on project docker-maven-plugin: Parameter 'sonar.pullrequest.branch' is mandatory for a pull request analysis -> [Help 1]

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #1275 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #1275   +/-   ##
=========================================
  Coverage     55.44%   55.44%           
- Complexity     1763     1764    +1     
=========================================
  Files           156      156           
  Lines          8487     8487           
  Branches       1304     1304           
=========================================
  Hits           4706     4706           
  Misses         3327     3327           
  Partials        454      454
Impacted Files Coverage Δ Complexity Δ
...config/handler/property/PropertyConfigHandler.java 75.52% <100%> (ø) 122 <0> (+1) ⬆️

Copy link
Collaborator

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! The sonar config was outdated btw.

@rhuss rhuss merged commit a3781b7 into fabric8io:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants