Fix #1384: Building spring-boot-with-jib fails with NoSuchMethodEror #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
force-pushed
the
pr/issue1384
branch
4 times, most recently
from
c160cca
to
b6349d1
Compare
…thodEror + Updating jib-core to 0.15.0 broke our current JIB support due to incompatibility with httpclient. Updated apache httpclient to 4.5.10 + Somehow behavior of Jib setting ImageFormat has been changed(maybe it was not working earlier. Introduced a new parameter in mojo `docker.build.jib.imageFormat` to allow users specify image format(OCI or Docker) with Docker as default ImageFormat. + Minor Cleanup in Integration tests; Added an integration test for JIB mode which builds image tarball and verifies it by loading into docker daemon This should also fix fabric8io#1385
rohanKanojia
force-pushed
the
pr/issue1384
branch
from
b6349d1
to
df34d97
Compare
rhuss
approved these changes
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1384
incompatibility with httpclient. Updated apache httpclient to 4.5.10
not working earlier. Introduced a new parameter in mojo
docker.build.jib.imageFormatto allow users specify image format(OCI or Docker) with Docker as
default ImageFormat.
which builds image tarball and verifies it by loading into docker daemon
This should also fix #1385