-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to dump the logs to an output file #1472
Conversation
There seem to be some test failures. Could you please address them? |
Hey @rohanKanojia good to see you here 🙂 ! |
Sonar is failing with:
probably because the PR is from a fork, not sure how to fix it, any guidance? |
Don't worry about it. We had removed secrets and disabled sonarcube integration due to recent Codecov vulnerability. We'll revisit it again in future. |
@rohanKanojia have you had the chance to review this PR? Anything I can do to give more context or any additional explanation? The plugin itself is amazing and I really enjoy it! |
Sorry for delay, I'll review your PR this weekend. You'll need a release after merging this change too? |
Truly appreciated @rohanKanojia ! |
@rohanKanojia ready for next review round 🙂 |
Could you please add a line to doc/changelog regarding this feature as well? It looks good to be merged 👍 |
@rohanKanojia added an entry to the changelog and rebased on latest master, thanks for bearing with me! |
Thanks! Do you have any ETA for the release? |
I will try to cut a release this weekend. Could you please test against master SNAPSHOT build to check everything is working as expected with your project? |
I can confirm that everything works as expected in my project thanks again 👍 |
This option is designed after:
https://maven.apache.org/plugins/maven-dependency-plugin/list-mojo.html#outputFile
Basically, it redirects the output logs to a file that can be processed by something else (another Mojo, external tools, etc.)
For context:
I'm working on Maven plugin that needs(in this case) to extract the pushed image
sha
.