-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inconsistent names of the entryPoint
configuration parameter
#1488
Conversation
Kudos, SonarCloud Quality Gate passed! |
I guess this is due to entrypoint field present in both BuildImageConfiguration BuildImageConfiguration: docker-maven-plugin/src/main/java/io/fabric8/maven/docker/config/BuildImageConfiguration.java Line 148 in 7d23d73
RunImageConfiguration: docker-maven-plugin/src/main/java/io/fabric8/maven/docker/config/RunImageConfiguration.java Line 52 in 7d23d73
|
So should I rename the property in |
entryPoint
configuration parameter
+1 for making the naming of the fields consistent in the code and name it docker-maven-plugin/src/main/java/io/fabric8/maven/docker/config/BuildImageConfiguration.java Lines 119 to 124 in 7d23d73
noCache , a similar issue)
For the document I would only use thanks ! |
maven error: > Unable to parse configuration of mojo io.fabric8:docker-maven-plugin:0.37.0:start for parameter entryPoint: Cannot find 'entryPoint' in class io.fabric8.maven.docker.config.RunImageConfiguration
Codecov Report
@@ Coverage Diff @@
## master #1488 +/- ##
============================================
- Coverage 62.13% 62.12% -0.01%
- Complexity 2173 2174 +1
============================================
Files 166 166
Lines 9554 9559 +5
Branches 1441 1442 +1
============================================
+ Hits 5936 5939 +3
- Misses 3107 3108 +1
- Partials 511 512 +1
|
Right now parameter field for ENTRYPOINT seems to be inconsistent across BuildImageConfiguration and RunImageConfiguration. Use `entryPoint` as parameter in all places and deprecate others: - `@Deprecate` `entrypoint` parameter field - Use `entryPoint` parameter field Signed-off-by: Rohan Kumar <[email protected]>
SonarCloud Quality Gate failed. |
maven 3.6.3 error: