Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop should respect docker.skip #1561

Merged
merged 1 commit into from
May 29, 2022

Conversation

doyleyoung
Copy link
Contributor

@doyleyoung doyleyoung commented May 27, 2022

When command line contains -Ddocker.skip and stop goal configuration contains <executeStopOnVMShutdown>true</executeStopOnVMShutdown> the following code still throws an error:

            if (!invokedTogetherWithDockerStart()) {
                throw new MojoExecutionException("docker:stop with executeStopOnVMShutdown is only possible if" +
                        " the docker containers started within the same maven session.");
            }

This execution should be skipped and there should not be an error.

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #1561 (6842111) into master (3dd6acd) will increase coverage by 0.00%.
The diff coverage is 75.00%.

❗ Current head 6842111 differs from pull request most recent head 77163ed. Consider uploading reports for the commit 77163ed to get more accurate results

@@            Coverage Diff            @@
##             master    #1561   +/-   ##
=========================================
  Coverage     62.64%   62.65%           
- Complexity     2139     2141    +2     
=========================================
  Files           170      170           
  Lines          9882     9886    +4     
  Branches       1354     1355    +1     
=========================================
+ Hits           6191     6194    +3     
  Misses         3176     3176           
- Partials        515      516    +1     
Impacted Files Coverage Δ
...rc/main/java/io/fabric8/maven/docker/StopMojo.java 44.34% <75.00%> (+1.10%) ⬆️

@sonarcloud
Copy link

sonarcloud bot commented May 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@rohanKanojia rohanKanojia merged commit f898132 into fabric8io:master May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants