Add support setting driverOpts for buildx #1704
Conversation
|
I think you should be able to add an integration test project in |
|
SonarCloud Quality Gate failed.
|
|
@Hellspam : polite ping, are you still working on this? |
Signed-off-by: Roy Arnon <[email protected]>
…builder + Add BuildXServiceCreateBuilderTest for verifying --driver-opt flag is passed while creating builder + Add buildx-driver-opt integration test Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
force-pushed
the
add-buildx-driveropts
branch
from
c22587f
to
1ea1004
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1704 +/- ##
============================================
+ Coverage 65.31% 65.33% +0.01%
- Complexity 2280 2284 +4
============================================
Files 172 172
Lines 10184 10191 +7
Branches 1406 1408 +2
============================================
+ Hits 6652 6658 +6
Misses 2983 2983
- Partials 549 550 +1
|
|
I recently had a use case where I wanted to change the builder image name to use an image from our local Artifactory instance.
To do that with the builder, I needed to add support for driverOpts to set
--driver-opt image=MY_IMAGE. Tested locally, seems to work fine.Regarding testing - I did not see any tests currently verifying the buildx create.
https://docs.docker.com/engine/reference/commandline/buildx_create/#driver-opt