Fix handling of Run Commands from properties. #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Newson <[email protected]>
Current coverage is 49.20% (diff: 100%)@@ master #684 diff @@
==========================================
Files 124 124
Lines 6357 6353 -4
Methods 0 0
Messages 0 0
Branches 1080 1079 -1
==========================================
Hits 3126 3126
+ Misses 2961 2959 -2
+ Partials 270 268 -2
|
Signed-off-by: Steve Newson <[email protected]>
rhuss
requested changes
Jan 23, 2017
| <id>sonatype-nexus-staging</id> | ||
| <name>Nexus Release Repository</name> | ||
| <url>https://oss.sonatype.org/service/local/staging/deploy/maven2/</url> | ||
| <id>starling-central</id> |
There was a problem hiding this comment.
guess this slipped in accidentally. Could you please revert this ?
| if (cmds == null) { | ||
| return null; | ||
| } | ||
| return ret; |
There was a problem hiding this comment.
Really stupid issue here. Thanks for spotting this !
|
Sure |
This reverts commit b49f0d0.
|
I've reverted the erroneous change. |
rhuss
approved these changes
Jan 24, 2017
|
thanks a lot, lgtm [merge] |
rgbj
pushed a commit
to rgbj/docker-maven-plugin
that referenced
this pull request
Jun 21, 2017
Fix handling of Run Commands from properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to source the run commands from properties.
Signed-off-by: Steve Newson [email protected]