#911 Fix NPE in LogCallback #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r the specified log file. Create the path leading to the file if missing. Signed-off-by: Ion Savin <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #940 +/- ##
============================================
+ Coverage 51.57% 51.57% +<.01%
Complexity 1232 1232
============================================
Files 144 144
Lines 7250 7251 +1
Branches 981 981
============================================
+ Hits 3739 3740 +1
Misses 3195 3195
Partials 316 316
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #911
Root cause:
${project.build.directory}(target/) doesn't exist and because of this an exception is thrown when attempting to create the SharedPrintStream totarget/postgres.log; the catch block tries to log to this SharedPrintStream which wasn't constructedSolution: create the dirs leading to the log file before opening the stream