-
Notifications
You must be signed in to change notification settings - Fork 202
Add regression test for multimodule project #1197
Comments
Hey @geoand We are using this regression test https://github.com/fabric8io/fabric8-maven-plugin/blob/master/rt/src/test/java/io/fabric8/maven/rt/SpringbootConfigmapBoosterIT.java Can you please check the test and guide if this is resolving the above-mentioned issue. Thanks |
Hello @piyush1594 It looks good to me, but I would also like to try and run it locally. |
Hey, Mentioning steps to run this test
Thanks |
Thank you @piyush1594 ! I'll try that later on and let you know :) |
The test looks good and mostly worked for me. It did fail once but for no apparent reason, the booster seemed to have been deployed correctly. |
Thanks a lot @geoand for helping and trying out this. Are we good to close this issue or something needs to be done w.r.t multimodule project. |
You are welcome!
I believe that the issue has been properly addressed, feel free to close.
Regards
…On Sun, Mar 25, 2018, 12:51 Piyush Garg ***@***.***> wrote:
Thanks a lot @geoand <https://github.com/geoand> for helping and trying
out this. Are we good to close this issue or something needs to be done
w.r.t multimodule project.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1197 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AELBv74_vugIpCiLsCZNTZg2b8G3qBs_ks5th2ibgaJpZM4SHHzZ>
.
|
@pradeepto @hrishin Can we close this? |
I am closing this. |
Right now, the regression test suite has 6 scenarios of deployment and redeployment. It does not have any related to multimodule project deployment and redeployment.
It will be good to have a scenario of the multimodule project in regression test suite.
#1184 is an issue related to the multimodule project which is failing. These kind of issues can be known before if we do so.
The text was updated successfully, but these errors were encountered: