Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Add regression test for multimodule project #1197

Closed
piyush-garg opened this issue Feb 15, 2018 · 9 comments
Closed

Add regression test for multimodule project #1197

piyush-garg opened this issue Feb 15, 2018 · 9 comments

Comments

@piyush-garg
Copy link
Collaborator

piyush-garg commented Feb 15, 2018

Right now, the regression test suite has 6 scenarios of deployment and redeployment. It does not have any related to multimodule project deployment and redeployment.

It will be good to have a scenario of the multimodule project in regression test suite.

#1184 is an issue related to the multimodule project which is failing. These kind of issues can be known before if we do so.

@pradeepto pradeepto changed the title Add a multimodule project in Regression test Add regression test for multimodule project Feb 26, 2018
@piyush-garg
Copy link
Collaborator Author

Hey @geoand

We are using this regression test https://github.com/fabric8io/fabric8-maven-plugin/blob/master/rt/src/test/java/io/fabric8/maven/rt/SpringbootConfigmapBoosterIT.java

Can you please check the test and guide if this is resolving the above-mentioned issue.

Thanks

@geoand
Copy link
Contributor

geoand commented Mar 23, 2018

Hello @piyush1594

It looks good to me, but I would also like to try and run it locally.
Do I need any special setup to do that, or will just using minishift and running the test work?

@piyush-garg
Copy link
Collaborator Author

piyush-garg commented Mar 23, 2018

Hey,

Mentioning steps to run this test

  1. Run minishift
  2. Clone FMP repo
  3. Hit cd fabric8-maven-plugin
  4. Hit mvn clean install -DskipTests
  5. Hit cd rt
  6. Hit mvn -Dtest="io.fabric8.maven.rt.SpringbootConfigmapBoosterIT" test

Thanks

@geoand
Copy link
Contributor

geoand commented Mar 23, 2018

Thank you @piyush1594 !

I'll try that later on and let you know :)

@geoand
Copy link
Contributor

geoand commented Mar 23, 2018

The test looks good and mostly worked for me. It did fail once but for no apparent reason, the booster seemed to have been deployed correctly.

@piyush-garg
Copy link
Collaborator Author

Thanks a lot @geoand for helping and trying out this. Are we good to close this issue or something needs to be done w.r.t multimodule project.

@geoand
Copy link
Contributor

geoand commented Mar 25, 2018 via email

@piyush-garg
Copy link
Collaborator Author

@pradeepto @hrishin Can we close this?

@piyush-garg
Copy link
Collaborator Author

I am closing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants