Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Fix VertxConfigmapBooster test #1153

Merged
merged 1 commit into from
Jan 12, 2018

Conversation

rohanKanojia
Copy link
Member

A recent change in vertx-configmap-booster project has caused the build
process to automatically create resources during build(see src/main/fabric8
in that project). So it's better to edit configmap after build process.
For more details, see openshift-vertx-examples/vertx-configmap-example@2afa3e1

A recent change in vertx-configmap-booster project has caused the build
process to automatically create resources during build(see src/main/fabric8
in that project). So it's better to edit configmap after build process.
Copy link
Member

@hrishin hrishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohanKanojia this looks good to me. At the same, this is alarming as well. Its better to move these regression tests close to booster projects.
WDYT?

@rohanKanojia
Copy link
Member Author

@hrishin : Hmm, agreed. I also feel that these booster regression tests should be coupled with those booster projects rather than fabric8 maven plugin.
Roland was also asking about moving these tests out of Fabric8 maven plugin, so maybe we can add them to a repo on that Github org, or maybe add them individually? But that would require configuring CI on each project.

@hrishin
Copy link
Member

hrishin commented Jan 10, 2018

@rohanKanojia agreed

@rohanKanojia
Copy link
Member Author

@hrishin : Thanks :) . Could we merge this small fix for now? I have created a separate issue for it. Let's move our discussion here

@rohanKanojia
Copy link
Member Author

@piyush1594 : Can you merge this, please?

@piyush-garg
Copy link
Collaborator

Thanks @rohanKanojia

LGTM, it is required as all the Travis builds for PR are getting failed, I am merging this. @hrishin

@piyush-garg piyush-garg merged commit 13ed745 into fabric8io:master Jan 12, 2018
@rohanKanojia rohanKanojia deleted the fixVertxConfigmapBooster branch January 16, 2018 07:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants