Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Fix #894: Service with NodePort always gets a new port after 'fabric8:apply' #1366

Merged
merged 3 commits into from
Sep 11, 2018

Conversation

rohanKanojia
Copy link
Member

#894

  • Whenever we detect that a resource with a certain name exists, edit()
    instead of doing replace()

@rhuss
Copy link
Contributor

rhuss commented Sep 4, 2018

Thanks a lot ! Let me review this tomorrow to give you feedback.

@rhuss rhuss self-requested a review September 4, 2018 13:53
rohanKanojia and others added 2 commits September 10, 2018 09:47
… 'fabric8:apply'

+ Whenever we detect that a resource with a certain name exists, edit()
  instead of doing replace()
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot ! I refactored the PatchService a bit (hope you don't mind).

It would be awesome if you could add some unit tests, too.

I did also the update to the ChangeLog.

@codecov
Copy link

codecov bot commented Sep 10, 2018

Codecov Report

Merging #1366 into master will increase coverage by 0.37%.
The diff coverage is 26.01%.

@@             Coverage Diff              @@
##             master    #1366      +/-   ##
============================================
+ Coverage     31.17%   31.55%   +0.37%     
- Complexity      947      984      +37     
============================================
  Files           171      172       +1     
  Lines          9738     9853     +115     
  Branches       1762     1779      +17     
============================================
+ Hits           3036     3109      +73     
- Misses         6381     6398      +17     
- Partials        321      346      +25

Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! LGTM

@rhuss rhuss merged commit c6ac72d into fabric8io:master Sep 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants