This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
#1628 - Fixing HELM mojo, replacing template placeholders in ResourceMojo, Fixing NPE in UndeployMojo #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging upstream
…Mojo, Fixing NPE in UndeployMojo
djotanov
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1642 +/- ##
============================================
- Coverage 34.81% 34.65% -0.17%
+ Complexity 1121 1120 -1
============================================
Files 186 186
Lines 10309 10348 +39
Branches 1679 1688 +9
============================================
- Hits 3589 3586 -3
- Misses 6299 6338 +39
- Partials 421 424 +3 |
Codecov Report
@@ Coverage Diff @@
## master #1642 +/- ##
============================================
- Coverage 34.8% 34.65% -0.16%
+ Complexity 1123 1120 -3
============================================
Files 186 186
Lines 10325 10349 +24
Branches 1681 1688 +7
============================================
- Hits 3594 3586 -8
- Misses 6307 6339 +32
Partials 424 424 |
rohanKanojia
requested review from
lordofthejars and
devang-gaur
and removed request for
lordofthejars
|
@djotanov : Have you tested it? Is it working for you? |
|
Yes, everything works for me. |
|
@djotanov : Great! Really Really appreciated 👏 |
|
one minor thing, could you please add a line to changelog also? |
rohanKanojia
added
the
pr/changelog-entry-please
|
Sure, done |
rohanKanojia
removed
the
pr/changelog-entry-please
lordofthejars
approved these changes
May 27, 2019
devang-gaur
approved these changes
May 28, 2019
9 tasks
manusa
added a commit
to manusa/jkube
that referenced
this pull request
Mar 18, 2020
Signed-off-by: Marc Nuri <[email protected]>
manusa
added a commit
to manusa/jkube
that referenced
this pull request
Mar 23, 2020
Signed-off-by: Marc Nuri <[email protected]>
manusa
added a commit
to manusa/jkube
that referenced
this pull request
Mar 24, 2020
Signed-off-by: Marc Nuri <[email protected]>
manusa
added a commit
to manusa/jkube
that referenced
this pull request
Mar 25, 2020
Signed-off-by: Marc Nuri <[email protected]>
manusa
added a commit
to eclipse-jkube/jkube
that referenced
this pull request
Mar 25, 2020
Signed-off-by: Marc Nuri <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1628
Creating PR based on analysis in #1628