Use install-plugins.sh instead of plugins.sh #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 4, 2016 15:48
…nearly) impossible to produce the same result for another build, really wanted?
rawlingsj
reviewed
Nov 9, 2016
| @@ -1,7 +1,7 @@ | |||
| FROM jenkins:2.19.1-alpine | |||
|
|
|||
| COPY plugins.txt /usr/share/jenkins/plugins.txt | |||
| RUN /usr/local/bin/plugins.sh /usr/share/jenkins/plugins.txt | |||
| RUN /usr/local/bin/install-plugins.sh $(cat /usr/share/jenkins/plugins.txt | tr '\n' ' ') | |||
There was a problem hiding this comment.
I wonder if we should just rename the https://github.com/fabric8io/jenkins-docker/blob/master/plugins.txt -> https://github.com/fabric8io/jenkins-docker/blob/master/plugins.sh ? Might make it a bit clearer what's going on.
There was a problem hiding this comment.
This would mean that the install-plugins.sh is calling plugins.sh. Do you think this makes sense? Or did I misunderstood your Point?
|
Thanks for this @triplem - just had a chance to take a proper look and I added a review comment. If you're happy with that maybe do the rename and squash the commits into a single one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #89
Three commits, the first one just replaces the used script, the second one replaces the concrete version of the plugins with the tag "latest". This will breach the concept that each build will produce the same result. The third one removes transient dependencies from the plugins.txt file.
I should have made the second commit after the third commit ;-(