Skip to content

Commit

Permalink
fix: Remove code smells
Browse files Browse the repository at this point in the history
  • Loading branch information
manusa committed May 13, 2021
1 parent 2248db8 commit 83c09ba
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
* Fix #2701: Better support for patching in KuberntesClient
* Fix #3034: Added a SharedInformer.isRunning method
* Fix #3088: mock server will assume /status is a subresource, and other refinements to match kube behavior
* Add DSL Support for `config.openshift.io/v1` resources in OpenShiftClient
* Fix #3111: Add DSL Support for `config.openshift.io/v1` resources in OpenShiftClient

#### _**Note**_: Breaking changes in the API
##### DSL Changes:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,7 @@
import io.fabric8.kubernetes.api.builder.Visitor;
import io.fabric8.openshift.client.OpenShiftConfig;
import io.fabric8.kubernetes.client.dsl.Resource;
import io.fabric8.kubernetes.client.dsl.base.HasMetadataOperation;
import io.fabric8.kubernetes.client.dsl.NonNamespaceOperation;
import io.fabric8.kubernetes.client.utils.ApiVersionUtil;
import io.fabric8.kubernetes.client.dsl.base.OperationContext;
import io.fabric8.openshift.client.OpenShiftConfig;
import io.fabric8.openshift.client.dsl.internal.OpenShiftOperation;

import okhttp3.OkHttpClient;
Expand All @@ -31,10 +27,6 @@
import io.fabric8.openshift.api.model.DNSBuilder;
import io.fabric8.openshift.api.model.DNSList;

import java.util.Map;
import java.util.TreeMap;


public class DNSOperationsImpl extends OpenShiftOperation<DNS, DNSList, Resource<DNS>> {

public DNSOperationsImpl(OkHttpClient client, OpenShiftConfig config) {
Expand All @@ -49,6 +41,7 @@ public DNSOperationsImpl(OperationContext context) {
this.listType = DNSList.class;
}

@Override
public DNSOperationsImpl newInstance(OperationContext context) {
return new DNSOperationsImpl(context);
}
Expand Down

0 comments on commit 83c09ba

Please sign in to comment.