-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce informer lifecycle #3050
Comments
Based on this assumption, would PR #3029 makes sense? |
I believe so - with the two changes from the comment. I'll make them as code comments to further clarify. |
shawkins
added a commit
to shawkins/kubernetes-client
that referenced
this issue
Apr 28, 2021
also removing the empty string return for last version when not started - it complicates checking the last resource version as you have to look for null and empty string to check for invalid values.
shawkins
added a commit
to shawkins/kubernetes-client
that referenced
this issue
Apr 28, 2021
also removing the empty string return for last version when not started - it complicates checking the last resource version as you have to look for null and empty string to check for invalid values.
shawkins
added a commit
to shawkins/kubernetes-client
that referenced
this issue
Apr 28, 2021
also removing the empty string return for last version when not started - it complicates checking the last resource version as you have to look for null and empty string to check for invalid values.
manusa
pushed a commit
to shawkins/kubernetes-client
that referenced
this issue
Apr 30, 2021
also removing the empty string return for last version when not started - it complicates checking the last resource version as you have to look for null and empty string to check for invalid values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It was discussed in #3048 as to what are the expectations for calling run after stop. The expectation is that stop should be a terminal state.
Related to this, SharedIndexInformer.addIndex is only allowed when not running, but SharedIndexInformer.getIndexer().addIndex will work always.
The text was updated successfully, but these errors were encountered: