Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch without a name fails unintuitively #3089

Closed
shawkins opened this issue May 7, 2021 · 1 comment
Closed

Patch without a name fails unintuitively #3089

shawkins opened this issue May 7, 2021 · 1 comment
Milestone
5.4.0

Comments

@shawkins
Copy link
Contributor

shawkins commented May 7, 2021

Starting with a resource that has a name and namespace:
Resource r = new Resource ... withNameSpace("namespace").withName("name") ...;

And issuing the patch:
client.customResources(MyResource.class).patch(resource);

Will fail because fromServer() will fetch a list. Is it expected that you need to specify the name and namespace when making a patch call?
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 10, 2021
@shawkins
additional changes for fabric8io#3089 and fabric8io#3066
f864014 
this consolidated the base patch support logic to a single method, adds
an applyStatus, and refines the patch(base, item) behavior when null
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 10, 2021
@shawkins
additional changes for fabric8io#3089 and fabric8io#3066
0ebdf53 
this consolidated the base patch support logic to a single method, adds
an applyStatus, and refines the patch(base, item) behavior when null
@shawkins shawkins mentioned this issue May 10, 2021
Merged
11 tasks
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue May 12, 2021
@shawkins @manusa
additional changes for fabric8io#3089 and fabric8io#3066
c1e7210 
this consolidated the base patch support logic to a single method, adds
an applyStatus, and refines the patch(base, item) behavior when null
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue May 13, 2021
@shawkins @manusa
additional changes for fabric8io#3089 and fabric8io#3066
1adb8c2 
this consolidated the base patch support logic to a single method, adds
an applyStatus, and refines the patch(base, item) behavior when null
manusa pushed a commit that referenced this issue May 13, 2021
@shawkins @manusa
additional changes for #3089 and #3066
d9224d0 
this consolidated the base patch support logic to a single method, adds
an applyStatus, and refines the patch(base, item) behavior when null
@shawkins
Copy link
Contributor Author

@manusa this was addressed by #3070

@manusa manusa added this to the 5.4.0 milestone May 13, 2021
@manusa manusa closed this as completed May 13, 2021
ddl-audi pushed a commit to ddl-audi/kubernetes-client that referenced this issue May 14, 2021
@shawkins @ddl-audi
additional changes for fabric8io#3089 and fabric8io#3066
3bfc093 
this consolidated the base patch support logic to a single method, adds
an applyStatus, and refines the patch(base, item) behavior when null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.4.0
Development

No branches or pull requests
2 participants
@manusa @shawkins