Refine the Informer Store interface #3091
Assignees
Milestone
Comments
11 tasks
|
@rohanKanojia a full proposal for refactoring after #3108 looks like shawkins#3 |
|
@shawkins : Thanks, let me review it later today 👍 |
shawkins
added a commit
to shawkins/kubernetes-client
that referenced
this issue
May 24, 2021
…sSynced splitting internal and mutative methods to SyncableStore removing isPopulated and directly wiring the cache to be used this adds an isRunning method to the SharedInformer. this clarifies the cache methods to be more like a map and the underlying map is now concurrent to remove read locks
shawkins
added a commit
to shawkins/kubernetes-client
that referenced
this issue
May 25, 2021
…sSynced splitting internal and mutative methods to SyncableStore removing isPopulated and directly wiring the cache to be used this adds an isRunning method to the SharedInformer. this clarifies the cache methods to be more like a map and the underlying map is now concurrent to remove read locks
shawkins
added a commit
to shawkins/kubernetes-client
that referenced
this issue
May 25, 2021
…sSynced splitting internal and mutative methods to SyncableStore removing isPopulated and directly wiring the cache to be used this adds an isRunning method to the SharedInformer. this clarifies the cache methods to be more like a map and the underlying map is now concurrent to remove read locks
manusa
pushed a commit
that referenced
this issue
Jun 9, 2021
splitting internal and mutative methods to SyncableStore removing isPopulated and directly wiring the cache to be used this adds an isRunning method to the SharedInformer. this clarifies the cache methods to be more like a map and the underlying map is now concurrent to remove read locks
|
Closed via #3167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are several options to improve the Store interface.
The most aggressive, which would deviate from the go client, would be to remove all of the mutative / internal methods to a separate interface - add, update, delete, replace, resync, isPopulated, hasSynced would be part of a - which would then no longer be directly exposed via the Indexer interface. The rationale is that these either have no-op behavior or should not be called directly.
A lesser refactoring would simply align the interface with the go client, such that newer methods added in fabric8 are moved to a separate interface.
Once #3061 is committed all of the cache methods can be type-safe - no need to reference the object type.
#3090 proposes removing the isPopulated method altogether.
The text was updated successfully, but these errors were encountered: