Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenRefreshInterceptor does not refresh with exec-based auth (AWS for instance) #3097

Closed
hypnoce opened this issue May 11, 2021 · 3 comments · Fixed by #3105
Closed

TokenRefreshInterceptor does not refresh with exec-based auth (AWS for instance) #3097

hypnoce opened this issue May 11, 2021 · 3 comments · Fixed by #3105
Assignees
Milestone

Comments

@hypnoce
Copy link
Contributor

hypnoce commented May 11, 2021

The TokenRefreshInterceptor checks for non nullity of the auto provider only to use it to check if it's "oidc". It falls back to autoconfiguration if the authtoken provider is not null and not oicd. But other type of auth (using exec...) may have auth provider null but still can be autoconfigured.
Code :

if (currentAuthInfo != null && currentAuthInfo.getAuthProvider() != null) {
.

Use case : aws eks can use use exec configuration to authenticate.

What do you think ?

@rohanKanojia
Copy link
Member

@hypnoce : Would you like to submit a PR to support this use case?

@hypnoce
Copy link
Contributor Author

hypnoce commented May 11, 2021

@rohanKanojia Working on it

hypnoce added a commit to hypnoce/kubernetes-client that referenced this issue May 12, 2021
hypnoce added a commit to hypnoce/kubernetes-client that referenced this issue May 12, 2021
hypnoce added a commit to hypnoce/kubernetes-client that referenced this issue May 12, 2021
hypnoce added a commit to hypnoce/kubernetes-client that referenced this issue May 12, 2021
hypnoce added a commit to hypnoce/kubernetes-client that referenced this issue May 12, 2021
@hypnoce
Copy link
Contributor Author

hypnoce commented May 12, 2021

@rohanKanojia PR done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants