Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review if patch(context, string) should handle the rolling case #3098

Closed
shawkins opened this issue May 11, 2021 · 1 comment
Closed

Review if patch(context, string) should handle the rolling case #3098

shawkins opened this issue May 11, 2021 · 1 comment
Assignees

Comments

@shawkins
Copy link
Contributor

shawkins commented May 11, 2021

return getRollingUpdater(rollingTimeout, rollingTimeUnit).rollUpdate(getMandatory(), t);
the old patch and other operations consider the rolling case separately. This should be reviewed if it is needed for the new patch(context, string) method and/or if the rolling case could be handled differently given the additional base logic that's now available.

This is related to #3070

@shawkins shawkins self-assigned this Jun 5, 2021
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 5, 2021
@shawkins
Copy link
Contributor Author

shawkins commented Jun 5, 2021

I opened #3221 after reviewing this issue - the changes are just to make the operation logic as consistent as possible. I saw that openshift operations should override the builder method and the other logic dealing with special case or modifying the item should better account for the patch logic.

shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 6, 2021
@manusa manusa closed this as completed in 8eb5211 Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant