Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace(item) should use the resourceVersion from the item if possible #3149

Closed
shawkins opened this issue May 20, 2021 · 0 comments
Closed

replace(item) should use the resourceVersion from the item if possible #3149

shawkins opened this issue May 20, 2021 · 0 comments
Assignees
@shawkins
Milestone
5.5.0

Comments

@shawkins
Copy link
Contributor

When not specifically locked on a version, replace(item) should see if the item has a resourceVersion set before retrieving the latest. If the replace fails, it can then get the latest on the next retry.
@shawkins shawkins mentioned this issue May 20, 2021
Closed
@shawkins shawkins self-assigned this May 20, 2021
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 24, 2021
@shawkins
fix fabric8io#3149 fabric8io#3127 deprecating updateStatus and enhanc…
3ee7905 
…ing replace

also consolidating more util calls, making some of the messages more
consistent, and trying the passed in resourceVersion first in a replace
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 26, 2021
@shawkins
fix fabric8io#3149 fabric8io#3127 deprecating updateStatus and enhanc…
a4756f2 
…ing replace

also consolidating more util calls, making some of the messages more
consistent, and trying the passed in resourceVersion first in a replace
@manusa manusa closed this as completed in 71c1a8c May 26, 2021
@manusa manusa added this to the 5.5.0 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
None yet
Projects
None yet
Milestone
5.5.0
Development

No branches or pull requests
2 participants
@manusa @shawkins