Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filterable modifies the current context #3275

Closed
shawkins opened this issue Jun 25, 2021 · 0 comments
Closed

Filterable modifies the current context #3275

shawkins opened this issue Jun 25, 2021 · 0 comments
Assignees
@shawkins

Comments

@shawkins
Copy link
Contributor

All of the Filterable methods modify then return the current context. Should they be creating new instances?

cc @rohanKanojia @manusa
@shawkins shawkins mentioned this issue Jun 26, 2021
Merged
11 tasks
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 27, 2021
@shawkins
fix fabric8io#3275: filterable should not modify the current context
924e886 
this introduces a builder for near backwards compatibility
@shawkins shawkins mentioned this issue Jun 27, 2021
Merged
11 tasks
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 27, 2021
@shawkins
fix fabric8io#3275: filterable should not modify the current context
9349fe0 
this introduces a builder for near backwards compatibility
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 27, 2021
@shawkins
fix fabric8io#3275: filterable should not modify the current context
af68f8f 
this introduces a builder for near backwards compatibility
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 27, 2021
@shawkins
fix fabric8io#3275: filterable should not modify the current context
84b4a4a 
this introduces a builder for near backwards compatibility
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 28, 2021
@shawkins
fix fabric8io#3275: filterable should not modify the current context
05a2d9d 
this introduces a builder for near backwards compatibility
@shawkins shawkins self-assigned this Jun 28, 2021
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 29, 2021
@shawkins
fix fabric8io#3275: filterable should not modify the current context
4425669 
this introduces a builder for near backwards compatibility
@manusa manusa closed this as completed in 8d0f823 Jun 29, 2021
@rohanKanojia rohanKanojia mentioned this issue Aug 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shawkins