Add ConversionReview to Kubernetes ApiExtensions Model

[rohanKanojia]

ConversionReview, ConversionRequest and ConversionResponse might be used by users who are interested in writing a conversion webhook in order to handle CustomResource conversions from one version to other.

You can find equivalent go struct here: https://github.com/kubernetes/apiextensions-apiserver/blob/master/pkg/apis/apiextensions/v1/types.go#L457

[MUzairS15]

Can I try on this?

[rohanKanojia]

Yes, sure. Here are the steps you need to follow in order to complete this:

1. Add ConversionReview in Kubernetes Model APIExtension generator:
   

   kubernetes-client/kubernetes-model-generator/kubernetes-model-apiextensions/cmd/generate/generate.go

   Line 80 in 9f0ce58

   V1JSONSchemaPropsOrStringArray v1apiextensions.JSONSchemaPropsOrStringArray

2. If you have golang installed run make to generate model.
3. Verify you have ConversionRequest.java, ConversionResponse.java, and ConversionReview.java generated.
4. Add test for basic serialization, deserialization of ConversionReview

[MUzairS15]

Pls assign me

[manusa]

There's no clear path to use these new types from CustomResourceDefinitionSpec#conversion ->
CustomResourceConversion#webhook -> WebhookConversion#conversionReviewVersions -> ...

Go structs: WebhookConversion#ConversionReviewVersions -> ?? -> ConversionReviewVersions

Do you have any example @rohanKanojia ?

[rohanKanojia]

Conversion webhooks for CRDs are launched in the cluster and put behind a Service object, and that service object is referenced by the conversion webhook specification in the CRD manifest.

I found these by a quick search on the web(written using client-go):

https://github.com/programming-kubernetes/pizza-crd
https://github.com/madorn/crd-conversion-webhook